Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READ via DESCRIBE query #541

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Jul 15, 2024

[0.86.0] - 15-07-24

Changed

  • NeatGraphStore.read() is now iterable utilizing DESCRIBE query instead of CONSTRUCT query.

Improved

  • Order of magnitude improved query speed of instances for downstream graph loaders

@nikokaoja nikokaoja requested a review from a team as a code owner July 15, 2024 12:42
Copy link

github-actions bot commented Jul 15, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22595 15763 70% 60% 🟢

New Files

File Coverage Status
cognite/neat/graph/transformers/_rdfpath.py 0% 🟢
TOTAL 0% 🟢

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/graph/loaders/_rdf2dms.py 75% 🟢
cognite/neat/graph/queries/_base.py 70% 🟢
cognite/neat/graph/queries/_construct.py 35% 🟢
cognite/neat/graph/stores/_base.py 67% 🟢
cognite/neat/rules/analysis/_information_rules.py 85% 🟢
cognite/neat/utils/utils.py 80% 🟢
TOTAL 73% 🟢

updated for commit: 22867b8 by action🐍

cognite/neat/graph/loaders/_rdf2dms.py Show resolved Hide resolved
cognite/neat/graph/queries/_base.py Outdated Show resolved Hide resolved
cognite/neat/graph/stores/_base.py Outdated Show resolved Hide resolved
cognite/neat/utils/utils.py Outdated Show resolved Hide resolved
Comment on lines +223 to +225
class_linkage: pd.DataFrame,
parent_col: str = "source_class",
child_col: str = "target_class",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a preference? Or do you have some sort of plugin that changes the style?

Not a big deal, but all these irrelevant multiline changes makes the PR a bit more difficult to review.

@nikokaoja nikokaoja merged commit a856f11 into main Jul 16, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-362-Batch-.read-of-triples-per-type branch July 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants